Fix TypeError: Argument 1 of Window.getComputedStyle does not implement interface Element.#15
Open
TonisPiip wants to merge 1 commit intoabinavseelan:masterfrom
Open
Fix TypeError: Argument 1 of Window.getComputedStyle does not implement interface Element.#15TonisPiip wants to merge 1 commit intoabinavseelan:masterfrom
TonisPiip wants to merge 1 commit intoabinavseelan:masterfrom
Conversation
1st: with prop getter method getElement, 2nd: Already existing method of children maping / cloning, do check for it being either a input text area 3ed: finding first occurrence of an input or textarea element. I wanted to have some warning in case there's multple, but linting forbade it. Also linting didn't like Element being used before it was Defined, despite it being a preexisting definition...,
Author
|
https://codesandbox.io/s/primereact-test-i1fxh I made this codebox to test with a component that has an input inside.. however it seems codesandbox isn't loading the right fork... might be getting it form npm still... very odd... I need to get to sleep... UPDATE: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #12 and likely #10
The issue is that if textarea / input isn't a direct child to the component it will send a react component to getCaretCoordinates
Solution for getting the correct element,
1st: with prop getter method getElement,
2nd: Already existing method of children maping / cloning, do check for it being either a input text area
3ed: finding first occurrence of an input or textarea element.
I wanted to have some warning in case there's multple, but linting forbade it. Also linting didn't like Element being used before it was Defined, despite it being a preexisting definition...,
Also Why the timeouts with 0ms?
With my fork where I'm using quill, I need to add ~1-5 ms to have quill update the cursor positon before the triger evaluates the position, but I don't get a reason for it now.