Skip to content

Sync Control API spec with latest Control API source#3403

Open
sacOO7 wants to merge 1 commit into
mainfrom
fix/dx-144-control-api-spec-sync
Open

Sync Control API spec with latest Control API source#3403
sacOO7 wants to merge 1 commit into
mainfrom
fix/dx-144-control-api-spec-sync

Conversation

@sacOO7

@sacOO7 sacOO7 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Brings static/open-specs/control-v1.yaml fully in line with the Control API implementation and its CI-enforced generated swagger document. After this change, a structural diff (schemas, paths, properties, required fields) between the two specs shows no remaining gaps.

Added

  • Rule target fields: exchange (amqp/external), primarySite + provisionedCapacity (postgres outbox and MongoDB ingress), watch (MongoDB ingress), status on amqp/external and Google Cloud Function create schemas
  • Legacy webhook rule type on rule_response (returned for batch-mode rules predating the http type)
  • Endpoints: GET /me/accounts and POST /help with their me_accounts, help_request and help_response schemas
  • inProgress + required lists on account/app stats responses

Fixed

  • Namespace schemas: missing type on conflationEnabled, incorrect batchingInterval description, nullable on batching/conflation fields, mutableMessages description now notes it requires persisted: true (per review feedback on [DX-144] Update control API spec for missing fields #3257)
  • key_response.name marked nullable; unsupported_rule_response.target allows additional properties
  • Docs page now points at the spec's new home in ably/docs (OpenAPI link + Postman import URL)

Deliberately excluded (per #3257 review)

batchingPolicy and batchingConflationKey — accepted by the Control API controller but not returned in responses nor part of the API's documented contract (see DX-789).

Verification

Every added field was verified against the Control API source (controllers, jbuilder views, schema definitions). The spec validates cleanly with Redocly (remaining warnings are pre-existing style conventions shared by the whole file).

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3caf79e9-04ec-40b7-8a3d-9924114ff441

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dx-144-control-api-spec-sync

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sacOO7 sacOO7 changed the title [DX-144] Sync Control API spec with latest Control API source Sync Control API spec with latest Control API source Jun 11, 2026
@sacOO7 sacOO7 marked this pull request as ready for review June 11, 2026 11:25
@sacOO7 sacOO7 requested a review from Copilot June 11, 2026 11:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Control API OpenAPI specification and associated docs to match the current Control API implementation / generated swagger, closing remaining structural gaps.

Changes:

  • Added new Control API endpoints (GET /me/accounts, POST /help) and their request/response schemas.
  • Expanded rule/target schemas (e.g., exchange, primarySite, provisionedCapacity, watch, legacy webhook rule response) and adjusted a few existing schema details (e.g., nullability, descriptions, required lists).
  • Updated the Control API docs page to point to the spec in its new location in ably/docs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
static/open-specs/control-v1.yaml Adds new endpoints/schemas and syncs multiple schema details to align with Control API output.
src/pages/docs/platform/account/control-api.mdx Updates OpenAPI and Postman-import references to the new spec location.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread static/open-specs/control-v1.yaml
Comment thread static/open-specs/control-v1.yaml
Comment thread static/open-specs/control-v1.yaml
Comment thread src/pages/docs/platform/account/control-api.mdx
@sacOO7 sacOO7 force-pushed the fix/dx-144-control-api-spec-sync branch from 5287f94 to 27f6152 Compare June 11, 2026 11:41
Brings static/open-specs/control-v1.yaml in line with the Control API
implementation and its generated swagger document:

- Add missing rule target fields: exchange (amqp/external), primarySite
  and provisionedCapacity (postgres outbox and mongodb ingress), watch
  (mongodb ingress), and status on amqp/external and Google Cloud
  Function create schemas
- Add legacy webhook rule type to rule_response for batch-mode rules
  created before the http rule type was introduced
- Add missing endpoints: GET /me/accounts and POST /help, with
  me_accounts, help_request and help_response schemas
- Add inProgress and required fields to account and app stats responses
- Fix namespace schemas: add missing type to conflationEnabled, correct
  batchingInterval description, mark batching and conflation fields
  nullable, and document that mutableMessages requires persisted
- Mark key_response name nullable and align unsupported rule target
  with additionalProperties true
- Point the docs page at the spec's new home in ably/docs
@sacOO7 sacOO7 force-pushed the fix/dx-144-control-api-spec-sync branch from 27f6152 to 5031308 Compare June 11, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants