Sync Control API spec with latest Control API source#3403
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the Control API OpenAPI specification and associated docs to match the current Control API implementation / generated swagger, closing remaining structural gaps.
Changes:
- Added new Control API endpoints (
GET /me/accounts,POST /help) and their request/response schemas. - Expanded rule/target schemas (e.g.,
exchange,primarySite,provisionedCapacity,watch, legacywebhookrule response) and adjusted a few existing schema details (e.g., nullability, descriptions, required lists). - Updated the Control API docs page to point to the spec in its new location in
ably/docs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| static/open-specs/control-v1.yaml | Adds new endpoints/schemas and syncs multiple schema details to align with Control API output. |
| src/pages/docs/platform/account/control-api.mdx | Updates OpenAPI and Postman-import references to the new spec location. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5287f94 to
27f6152
Compare
Brings static/open-specs/control-v1.yaml in line with the Control API implementation and its generated swagger document: - Add missing rule target fields: exchange (amqp/external), primarySite and provisionedCapacity (postgres outbox and mongodb ingress), watch (mongodb ingress), and status on amqp/external and Google Cloud Function create schemas - Add legacy webhook rule type to rule_response for batch-mode rules created before the http rule type was introduced - Add missing endpoints: GET /me/accounts and POST /help, with me_accounts, help_request and help_response schemas - Add inProgress and required fields to account and app stats responses - Fix namespace schemas: add missing type to conflationEnabled, correct batchingInterval description, mark batching and conflation fields nullable, and document that mutableMessages requires persisted - Mark key_response name nullable and align unsupported rule target with additionalProperties true - Point the docs page at the spec's new home in ably/docs
27f6152 to
5031308
Compare
Brings
static/open-specs/control-v1.yamlfully in line with the Control API implementation and its CI-enforced generated swagger document. After this change, a structural diff (schemas, paths, properties, required fields) between the two specs shows no remaining gaps.Added
exchange(amqp/external),primarySite+provisionedCapacity(postgres outbox and MongoDB ingress),watch(MongoDB ingress),statuson amqp/external and Google Cloud Function create schemaswebhookrule type onrule_response(returned for batch-mode rules predating thehttptype)GET /me/accountsandPOST /helpwith theirme_accounts,help_requestandhelp_responseschemasinProgress+requiredlists on account/app stats responsesFixed
typeonconflationEnabled, incorrectbatchingIntervaldescription,nullableon batching/conflation fields,mutableMessagesdescription now notes it requirespersisted: true(per review feedback on [DX-144] Update control API spec for missing fields #3257)key_response.namemarked nullable;unsupported_rule_response.targetallows additional propertiesably/docs(OpenAPI link + Postman import URL)Deliberately excluded (per #3257 review)
batchingPolicyandbatchingConflationKey— accepted by the Control API controller but not returned in responses nor part of the API's documented contract (see DX-789).Verification
Every added field was verified against the Control API source (controllers, jbuilder views, schema definitions). The spec validates cleanly with Redocly (remaining warnings are pre-existing style conventions shared by the whole file).
🤖 Generated with Claude Code