DX-1128: localise syntax-highlighter util + registry#3415
Draft
jamiehenson wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jun 17, 2026
jamiehenson
force-pushed
the
dx-1128/docs-producttile
branch
from
70e3af1 to
99f78c8
Compare
jamiehenson
force-pushed
the
dx-1128/docs-syntax-highlighter
branch
from
f0aa029 to
712dec4
Compare
jamiehenson
force-pushed
the
dx-1128/docs-producttile
branch
from
99f78c8 to
d9a67e2
Compare
jamiehenson
force-pushed
the
dx-1128/docs-syntax-highlighter
branch
from
712dec4 to
2218333
Compare
jamiehenson
force-pushed
the
dx-1128/docs-producttile
branch
from
d9a67e2 to
d53ff7f
Compare
jamiehenson
force-pushed
the
dx-1128/docs-syntax-highlighter
branch
from
2218333 to
2f0072c
Compare
Vendor syntax-highlighter.js (highlight + line-highlight helpers) and syntax-highlighter-registry.js (the highlight.js language set) into src/utilities/ (DX-1128). Promote highlight.js + highlightjs-curl to direct deps (were transitive). Repoint CodeBlock + tests + setupTests off @ably/ui/core/utils/syntax-highlighter*. Base of the code-rendering chain (PR E / Code + CodeSnippet builds on this). Also firms up the highlight.js dependency that PR1's vendored syntax-highlighter.css relies on. eslint clean. Refs: DX-1128
jamiehenson
force-pushed
the
dx-1128/docs-producttile
branch
from
d53ff7f to
52b61ec
Compare
jamiehenson
force-pushed
the
dx-1128/docs-syntax-highlighter
branch
from
2f0072c to
b67f0f1
Compare
This was referenced Jun 18, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of DX-1128. Localises the syntax-highlighter utility + language registry.
What
src/utilities/syntax-highlighter.js+syntax-highlighter-registry.js, vendored from@ably/ui.highlight.js(+highlightjs-curl) promoted to direct deps (were transitive via@ably/ui).CodeBlockrewired to the local util.Behaviour
No visual change intended.
Stack (DX-1128)
@ably/uitokens + reset/core CSScn+heightsutilsIconcomponent@ably/uiTailwind scanmain)#3409–#3416 are a linear stack (each builds on the previous); #3417 is the combined view. ▶ = this PR.
Testing
🤖 Generated with Claude Code