Add rule for CKSource Holding copyright#4649
Open
Kaushik-Kumar-CEG wants to merge 1 commit intoaboutcode-org:developfrom
Open
Add rule for CKSource Holding copyright#4649Kaushik-Kumar-CEG wants to merge 1 commit intoaboutcode-org:developfrom
Kaushik-Kumar-CEG wants to merge 1 commit intoaboutcode-org:developfrom
Conversation
52561be to
2ff5c23
Compare
Signed-off-by: Kaushik <kaushikrjpm10@gmail.com>
2ff5c23 to
bf48b95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4583
Problem
CKEditor 5 files are incorrectly detected with extra licenses they don't contain.
Current (incorrect):
Expected (correct):
Root Cause
The generic CKSource rule matches both CKEditor 4 and CKEditor 5, but CKEditor 5 uses a different copyright holder ("CKSource Holding sp. z o.o.") and doesn't include LGPL/MPL licenses.
Solution
Added a specific rule that matches the "CKSource Holding sp. z o.o." copyright header used exclusively in CKEditor 5 packages. This rule takes precedence and returns the correct license expression.
Testing
@ckeditor/ckeditor5-special-characters@43.0.0Changes
gpl-2.0-plus_or_commercial-license_cksource_1.RULETasks: