Add license rule for LGPL-3.0-or-later notice pattern#4661
Open
harpreet-2146 wants to merge 1 commit intoaboutcode-org:developfrom
Open
Add license rule for LGPL-3.0-or-later notice pattern#4661harpreet-2146 wants to merge 1 commit intoaboutcode-org:developfrom
harpreet-2146 wants to merge 1 commit intoaboutcode-org:developfrom
Conversation
Fixes aboutcode-org#3935 Adds detection rule for the license notice pattern: 'Distributed under the terms of the GNU Lesser General Public License, either version 3 of the License, or (at your option) any later version.' This pattern was previously misdetected due to partial matching. Signed-off-by: harpreet kaur gothra <harpreetk2146@gmail.com>
harpreet-2146
force-pushed
the
fix-lgpl-3.0-detection-3935
branch
from
405273a to
c754945
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3935
Adds detection rule for the license notice pattern:
'Distributed under the terms of the GNU Lesser General Public License,
either version 3 of the License, or (at your option) any later version.'
This pattern was previously misdetected as
lgpl-2.1-plusdue to partial matching of 'GNU Lesser General Public License' without the version 3 context. The new rule matches the complete two-line notice and correctly identifies it aslgpl-3.0-plus.Testing done:
lgpl-2.1-plus AND lgpl-3.0-plusto justlgpl-3.0-plusscancode-reindex-licensesTasks
Signed-off-by: Harpreet Kaur Gothra harpreetk2146@gmail.com