Mark two-segment CamelCase code identifiers as JUNK - Fix #4736#4737
Open
alexmohr wants to merge 1 commit intoaboutcode-org:developfrom
Open
Mark two-segment CamelCase code identifiers as JUNK - Fix #4736#4737alexmohr wants to merge 1 commit intoaboutcode-org:developfrom
alexmohr wants to merge 1 commit intoaboutcode-org:developfrom
Conversation
This prevents false author detections. Words like MeterProvider, TracerProvider, and SpanProcessor in code comments match the "created by a <NNP>" grammar pattern, producing false author detections. The existing CamelCase JUNK rule only catches three or more segments (e.g. GetQueueReference). This adds a targeted rule for two-segment CamelCase words ending in common code suffixes (Provider, Processor, Exporter, Handler, Factory, etc.) so they are tagged as JUNK. Signed-off-by: Alexander Mohr <alexander.m.mohr@mercedes-benz.com>
Author
|
The errors in the pipeline seem unrelated to my changes, as the interupt tests should not be affected by the changes I made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents false author detections.
Words like MeterProvider, TracerProvider, and SpanProcessor in code comments match the "created by a " grammar pattern, producing false author detections. The existing CamelCase JUNK rule only catches three or more segments (e.g. GetQueueReference). This adds a targeted rule for two-segment CamelCase words ending in common code suffixes (Provider, Processor, Exporter, Handler, Factory, etc.) so they are tagged as JUNK.
Fixes #4736
Tasks
Run tests locally to check for errors.
Alexander Mohr alexander.m.mohr@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH
Provider Information