Skip to content

Conversation

@maliming
Copy link
Member

Resolve #24465

Publish a local event StaticPermissionDefinitionChangedEvent to clear the cache and write it to the database if the PermissionDefinition changed.

@maliming maliming changed the base branch from dev to rel-10.0 December 28, 2025 04:40
@maliming maliming marked this pull request as ready for review December 28, 2025 04:40
Copilot AI review requested due to automatic review settings December 28, 2025 04:40

This comment was marked as outdated.

@maliming maliming marked this pull request as draft December 28, 2025 05:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated 19 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 28, 2025

Codecov Report

❌ Patch coverage is 66.53144% with 165 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.02%. Comparing base (0627ca1) to head (db98067).
⚠️ Report is 19 commits behind head on rel-10.0.

Files with missing lines Patch % Lines
...Abp/FeatureManagement/FeatureDynamicInitializer.cs 59.40% 34 Missing and 7 partials ⚠️
...rmissionManagement/PermissionDynamicInitializer.cs 71.56% 23 Missing and 6 partials ⚠️
...Abp/SettingManagement/SettingDynamicInitializer.cs 71.28% 23 Missing and 6 partials ⚠️
...ment/StaticFeatureDefinitionChangedEventHandler.cs 0.00% 20 Missing ⚠️
...t/StaticPermissionDefinitionChangedEventHandler.cs 0.00% 20 Missing ⚠️
...ment/StaticSettingDefinitionChangedEventHandler.cs 0.00% 16 Missing ⚠️
...olo/Abp/StaticDefinitions/StaticDefinitionCache.cs 69.23% 4 Missing ⚠️
.../Volo/Abp/Features/StaticFeatureDefinitionStore.cs 93.02% 2 Missing and 1 partial ⚠️
...bp/TextTemplating/StaticTemplateDefinitionStore.cs 82.35% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           rel-10.0   #24487      +/-   ##
============================================
- Coverage     51.03%   51.02%   -0.01%     
============================================
  Files          3287     3294       +7     
  Lines        107304   107441     +137     
  Branches       8247     8255       +8     
============================================
+ Hits          54762    54823      +61     
- Misses        50855    50923      +68     
- Partials       1687     1695       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maliming maliming requested a review from salihozkara December 29, 2025 00:55
@maliming maliming added this to the 10.0-patch milestone Dec 29, 2025
@salihozkara salihozkara merged commit 153c44b into rel-10.0 Dec 29, 2025
3 checks passed
@salihozkara salihozkara deleted the 24465 branch December 29, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Refresh / Invalidate StaticPermissionDefinitionStore Cache at Runtime

3 participants