Skip to content

[electrophysiology_browser] Fix typo which breaks timeSelection#10451

Open
jeffersoncasimir wants to merge 1 commit intoaces:28.0-releasefrom
jeffersoncasimir:2026_04_17_fix_eeg_time_selection
Open

[electrophysiology_browser] Fix typo which breaks timeSelection#10451
jeffersoncasimir wants to merge 1 commit intoaces:28.0-releasefrom
jeffersoncasimir:2026_04_17_fix_eeg_time_selection

Conversation

@jeffersoncasimir
Copy link
Copy Markdown
Contributor

@jeffersoncasimir jeffersoncasimir commented Apr 17, 2026

@jeffersoncasimir jeffersoncasimir added Category: Bug PR or issue that aims to report or fix a bug Language: Javascript PR or issue that update Javascript code Module: electrophysiology_browser PR or issue related to electrophysiology_browser module labels Apr 17, 2026
@jeffersoncasimir jeffersoncasimir changed the base branch from main to 27.0-release April 17, 2026 15:54
@jeffersoncasimir jeffersoncasimir changed the base branch from 27.0-release to main April 17, 2026 15:59
@jeffersoncasimir jeffersoncasimir changed the base branch from main to 28.0-release April 17, 2026 16:01
@jeffersoncasimir jeffersoncasimir force-pushed the 2026_04_17_fix_eeg_time_selection branch from 7bbe7da to 598f646 Compare April 17, 2026 16:02
Copy link
Copy Markdown
Contributor

@MaximeBICMTL MaximeBICMTL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, very fast PR, thanks! This fixes the issue for me 👍

@driusan would like this to also be ported to main whenever possible so I can update my local branches.

@maximemulder maximemulder added the Difficulty: Trivial PR or issue whose implementation is obviously correct and no-risk (typo, formatting...) label Apr 18, 2026
@driusan
Copy link
Copy Markdown
Collaborator

driusan commented Apr 20, 2026

@jeffersoncasimir I think this needs to be rebased to fix the tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category: Bug PR or issue that aims to report or fix a bug Difficulty: Trivial PR or issue whose implementation is obviously correct and no-risk (typo, formatting...) Language: Javascript PR or issue that update Javascript code Module: electrophysiology_browser PR or issue related to electrophysiology_browser module

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

4 participants