Skip to content

[candidate_list] Translate Entity Type#10461

Merged
driusan merged 1 commit intoaces:mainfrom
driusan:TranslateCandidateListEntityType
Apr 24, 2026
Merged

[candidate_list] Translate Entity Type#10461
driusan merged 1 commit intoaces:mainfrom
driusan:TranslateCandidateListEntityType

Conversation

@driusan
Copy link
Copy Markdown
Collaborator

@driusan driusan commented Apr 24, 2026

This translates the Entity Type on the candidate_list page.

Note that even though the values are a known enum, they have to be translated on the PHP side so that projects can override other aspects of the candidate table (ie. Ethnicity) in project/locale.

@github-actions github-actions Bot added Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: candidate_list PR or issue related to candidate_list module labels Apr 24, 2026
@driusan driusan assigned kongtiaowang and unassigned kongtiaowang Apr 24, 2026
@driusan driusan added Multilingual Any tasks related to making LORIS multilingual labels Apr 24, 2026
Copy link
Copy Markdown
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driusan driusan force-pushed the TranslateCandidateListEntityType branch from 7afb621 to 3a46ac4 Compare April 24, 2026 19:27
@driusan driusan merged commit 3c8955f into aces:main Apr 24, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Module: candidate_list PR or issue related to candidate_list module Multilingual Any tasks related to making LORIS multilingual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants