[main.tpl] Translate Site List in main template#10467
Open
[main.tpl] Translate Site List in main template#10467
Conversation
Translate the site names in the main.tpl template based on the logged in user's locale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translate the site names in the main.tpl template based on the logged in user's locale.
There are multiple functions in the user class that get a list of sites.
Option 1 was used to populate the site list in the main template. However, it can not be updated to be translated without breaking the API and making it user specific, as it's also used in the API.
Option 3 returns a site singleton, which can be used to get the site name with an array_map, so is the most powerful option. The middleware is updated to use that.
Option 2 did not have any references in the code, so it is deleted here as it's redundant.