[NDB_Client] Remove guard on session_cache_limiter#9980
Open
[NDB_Client] Remove guard on session_cache_limiter#9980
Conversation
driusan
added
Category: Bug
driusan
force-pushed
the
PrivateSessionCache
branch
from
6d2d41f to
e528d00
Compare
driusan
force-pushed
the
PrivateSessionCache
branch
from
e528d00 to
c21e3b6
Compare
driusan
force-pushed
the
PrivateSessionCache
branch
from
c21e3b6 to
4e1caf0
Compare
driusan
force-pushed
the
PrivateSessionCache
branch
from
4e1caf0 to
7619987
Compare
All logged in user session data is private. There is no reason to restrict the session_cache_limiter to the API. (In fact, it is a bad idea.)
driusan
force-pushed
the
PrivateSessionCache
branch
from
7619987 to
837dcc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All logged in user session data is private. There is no reason to restrict the session_cache_limiter to the API. (In fact, it is a bad idea.)