Clean redundant Boutiques module log messages in BrainPortal/lib#1619
Open
RafsanNeloy wants to merge 1 commit intoaces:masterfrom
Open
Clean redundant Boutiques module log messages in BrainPortal/lib#1619RafsanNeloy wants to merge 1 commit intoaces:masterfrom
BrainPortal/lib#1619RafsanNeloy wants to merge 1 commit intoaces:masterfrom
Conversation
Member
|
Hi @RafsanNeloy Thanks, I reviewed all the changes and they're all good. I'd merge this PR except for one detail: it seems all the files you modified changed permissions from 644 to 755. Please make sure your work environment is set up properly to maintain file permissions. These are source code files, not executable files, after all. Once the permissions are adjusted I'll merge the PR. |
RafsanNeloy
force-pushed
the
Boutique_Module
branch
from
cafc6a9 to
c1a0632
Compare
Contributor
Author
|
Hi @prioux , |
Member
|
Hi! It all seems good to me. Will review one last time a bit later and then merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated log messages across multiple modules to remove redundant class/module names and improve readability.
Fixes #1618