Skip to content

Fix artifact name used if skipArchive is set to false #2448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NotTheEvilOne wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix artifact name used if skipArchive is set to false #2448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/artifact/__tests__/upload-artifact.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ describe('upload-artifact', () => {
)
})

it('should use the file basename as artifact name when skipArchive is true', async () => {
it('should use the artifact name as well when skipArchive is true', async () => {
jest
.spyOn(uploadZipSpecification, 'getUploadZipSpecification')
.mockRestore()
Expand Down Expand Up @@ -643,10 +643,10 @@ describe('upload-artifact', () => {
{skipArchive: true}
)

// Verify CreateArtifact was called with the file basename, not the original name
// Verify CreateArtifact was called with the original name
expect(createArtifactSpy).toHaveBeenCalledWith(
expect.objectContaining({
name: 'file1.txt'
name: 'original-name'
})
)
})
Expand Down
1 change: 0 additions & 1 deletion packages/artifact/src/internal/upload/upload-artifact.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ export async function uploadArtifact(
}

artifactFileName = path.basename(files[0])
name = artifactFileName
}

validateArtifactName(name)
Expand Down