Catch AbortError rejections from overlapping toast view transitions#10341
Open
Prajwalraut29 wants to merge 1 commit into
Open
Catch AbortError rejections from overlapping toast view transitions#10341Prajwalraut29 wants to merge 1 commit into
Prajwalraut29 wants to merge 1 commit into
Conversation
Author
|
hey @devongovett, check my PR |
snowystinger
left a comment
snowystinger
left a comment
Member
There was a problem hiding this comment.
Can we get a test? We have a browser suite that can be run with yarn test:browser
It'd be good to prove that this will fix the issue you're seeing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10337
When overlapping toasts trigger back-to-back
document.startViewTransition()calls, the skipped/preempted transition rejects its promises withAbortError: Transition was skipped. The starter templates and v1 ToastContainer only caught.ready(v1) or nothing at all (starters), resulting in unhandled promise rejections.This fix adds
.catch(() => {})on all threeViewTransitionpromises (finished,ready,updateCallbackDone) in all three locations:starters/docs/src/Toast.tsxstarters/tailwind/src/Toast.tsxpackages/@adobe/react-spectrum/src/toast/ToastContainer.tsx