Skip to content

fix(calendar): support RangeCalendar selection inside shadow DOM#10350

Closed
jsmitrah wants to merge 1 commit into
adobe:mainfrom
jsmitrah:fix/10330/rangecalendar-inside-shadow-dom-click
Closed

fix(calendar): support RangeCalendar selection inside shadow DOM#10350
jsmitrah wants to merge 1 commit into
adobe:mainfrom
jsmitrah:fix/10330/rangecalendar-inside-shadow-dom-click

Conversation

@jsmitrah

Copy link
Copy Markdown

Closes #10330

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

  • Go to the range calendar picker and click a date to set the start of the range, then click a second date to set the end in the Shadow DOM.
  • Verify: The calendar should wait for the second click to commit the full multi-day range, rather than incorrectly committing start==end immediately on the first click.

🧢 Your Project:

@snowystinger

Copy link
Copy Markdown
Member

Dupe of #10347
Any reason why you opened this one instead of commenting on the open PR?

@jsmitrah

Copy link
Copy Markdown
Author

@snowystinger When I saw this issue, there was no PR created, and it looked like a simple fix. So I worked on it and created a PR. Only afterward did I realize that someone had already created a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RangeCalendar inside shadow DOM commits range on first click (endDragging uses retargeted e.target)

2 participants