wip: support icons inside of S2 DisclosureTitle#9934
Draft
Conversation
|
Build successful! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9797
since there weren't any designs for this, i based the spacing between the icon + label off of S2 ListView. the rest of the spacing, like the padding between the edge + chevron or the chevron + label (or icon), i left the same as it was previously.
we should probably talk to design about this before we proceed but figured we could get more movement on it if we had something to present
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: