Skip to content

wip: support icons inside of S2 DisclosureTitle#9934

Draft
yihuiliao wants to merge 3 commits intomainfrom
accordion-icons
Draft

wip: support icons inside of S2 DisclosureTitle#9934
yihuiliao wants to merge 3 commits intomainfrom
accordion-icons

Conversation

@yihuiliao
Copy link
Copy Markdown
Member

Closes #9797

since there weren't any designs for this, i based the spacing between the icon + label off of S2 ListView. the rest of the spacing, like the padding between the edge + chevron or the chevron + label (or icon), i left the same as it was previously.

we should probably talk to design about this before we proceed but figured we could get more movement on it if we had something to present

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@github-actions github-actions bot added the S2 label Apr 16, 2026
@yihuiliao yihuiliao marked this pull request as draft April 16, 2026 00:28
@rspbot
Copy link
Copy Markdown

rspbot commented Apr 16, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Center S2 icons vertically inside the AccordionItemTitle

2 participants