This repository was archived by the owner on Sep 27, 2021. It is now read-only.
Add optional callback description on sync method#367
Open
jpdemagalhaes wants to merge 1 commit intoadonisjs:4.1from
Open
Add optional callback description on sync method#367jpdemagalhaes wants to merge 1 commit intoadonisjs:4.1from
jpdemagalhaes wants to merge 1 commit intoadonisjs:4.1from
Conversation
Contributor
Author
|
@RomainLanz any chance you can merge this one? Or is there anything else to be done on this PR? |
|
Does this callback return the array index as a parameter too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
syncmethod also accepts an optional callback (just as theattachmethod), but there wasn't any indicators of this possibility on the docs, hence, this PR.This adds a description and an example on the docs, hopefully, giving devs more clarity on what's available 😄