fix: tcp-user-timeouts requires socket2 all feature#369
Open
goto-bus-stop wants to merge 1 commit intoaembke:mainfrom
Open
fix: tcp-user-timeouts requires socket2 all feature#369goto-bus-stop wants to merge 1 commit intoaembke:mainfrom
tcp-user-timeouts requires socket2 all feature#369goto-bus-stop wants to merge 1 commit intoaembke:mainfrom
Conversation
socket2's `set_tcp_user_timeout` is gated behind the "all" feature: https://github.com/rust-lang/socket2/blob/c8146aa5bb839004208bfd89267ec61a7774386e/src/sys/unix.rs#L2605-L2608 In the fred.rs repository, the "all" feature is enabled by a different dependency (at least `monoio`, maybe others, I didn't check everything). But user projects might fail to compile if they don't happen to have a different dependency that enables it ^^
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
socket2's
set_tcp_user_timeoutis gated behind the "all" feature: https://github.com/rust-lang/socket2/blob/c8146aa5bb839004208bfd89267ec61a7774386e/src/sys/unix.rs#L2605-L2608In the fred.rs repository, the "all" feature is enabled by a different dependency (at least
monoio, maybe others, I didn't check everything). But user projects might fail to compile if they don't happen to have a different dependency that enables it ^^