Show loading screen while downloading images assets#5779
Merged
dmarcos merged 1 commit intoaframevr:masterfrom Dec 19, 2025
Merged
Show loading screen while downloading images assets#5779dmarcos merged 1 commit intoaframevr:masterfrom
dmarcos merged 1 commit intoaframevr:masterfrom
Conversation
… so we see the loading screen while images are loading
Contributor
Author
|
You can test it on the 360 image example examples/boilerplate/panorama/index.html with Chrome network tab set to Slow 4G for example. |
Contributor
Author
|
Note that if the timeout is hit, the loading screen will still show until all images are loaded (triggering the readyState complete), then the loading screen hide and we can still have some a-asset-item elements downloading. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Set timeout mechanism and loading screen earlier at interactive state so we see the loading screen while images are loading.
That was a regression since 0d97218 where we changed everything to wait on complete state that includes DOM ready and resources like images loaded.
Changes proposed:
PR done with the help of Claude Code with Opus 4.5