Adds login redirect after authentication#1683
Open
neurocis wants to merge 1 commit into
Open
Conversation
3clyp50
requested changes
Jun 1, 2026
Contributor
3clyp50
left a comment
3clyp50
left a comment
There was a problem hiding this comment.
Thanks for the UX improvement. I rebased this locally onto ready; there is one blocker before merge: the redirect safety check still allows a backslash open-redirect form.
| """Return True when value is a safe same-origin redirect target.""" | ||
| if not value: | ||
| return False | ||
| if "\r" in value or "\n" in value: |
Contributor
There was a problem hiding this comment.
This should also reject \. next=/%5Cevil.example passes validation, Flask sends Location: /\evil.example, and browsers normalize that to an external navigation. Please add a regression test for this case too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pushing to main as development seems stale atm.
Improves user experience by redirecting users to their intended page upon successful login. Implements secure URL validation to prevent open redirect vulnerabilities and supports both server-side and client-side redirects.
How to Test
nextparameter.nextURL to ensure redirection only occurs to safe, same-origin paths.Breaking Changes
None.