Use umbrella chart for platform Argo app#525
Conversation
Test & Lint SummaryCommands run:
Results:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Found blocking issues in the umbrella chart wiring. Please address the inline comments before merge.
|
Addressed Noa's requested changes:
Test & Lint SummaryCommands run:
Results:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete. The requested umbrella chart wiring fixes are present: authorization keeps the OpenFGA ConfigMap wiring, and notifications now points Redis at the umbrella release service. Approving.
|
CI failed: Argo rejected Application because Helm render hit agyn-platform secret contract check: (agyn-platform/templates/secret-contract-checks.yaml:123). Likely the Secret isn’t created in the platform namespace before the Application is created/rendered. Fix: ensure is in namespace and add it to (and/or ensure namespace creation ordering). |
|
Addressed the CI failures on this PR. Summary
Test & Lint SummaryCommands run:
Results:
|
|
Addressed the secret prerequisite ordering called out in the CI failure thread. Summary
Test & Lint SummaryCommands run:
Results:
|
Summary
platformApplication deployingagynio/charts/agyn-platform.apply.shand health verification expectations to wait onplatforminstead of individual platform microservice Applications.platformautosync after health verification by patchingspec.syncPolicy.automated.enabled=false.Closes #524
Validation
terraform -chdir=stacks/apps validateterraform -chdir=stacks/platform validateterraform -chdir=stacks/platform fmt -check -diffterraform -chdir=stacks/apps fmt -check -diffbash -n apply.sh .github/scripts/verify_platform_health.sh .github/scripts/disable_platform_autosync.sh install-ca-cert.shshellcheck apply.sh .github/scripts/verify_platform_health.sh .github/scripts/disable_platform_autosync.sh install-ca-cert.shgit diff --check