Skip to content

[PR #6547/65de218c backport][3.15] Remove overlapping slots and fix broken slots inheritance - #13466

Draft
webknjaz wants to merge 1 commit into
aio-libs:3.15from
webknjaz:patchback/backports/3.15/65de218c6297284663eeae5c07e9146ef1e4485e/pr-6547/handcrafted-cherry-pick-by-webknjaz
Draft

[PR #6547/65de218c backport][3.15] Remove overlapping slots and fix broken slots inheritance#13466
webknjaz wants to merge 1 commit into
aio-libs:3.15from
webknjaz:patchback/backports/3.15/65de218c6297284663eeae5c07e9146ef1e4485e/pr-6547/handcrafted-cherry-pick-by-webknjaz

Conversation

@webknjaz

Copy link
Copy Markdown
Member

This is a (manual) backport of PR #6547 as merged into master (65de218).


(looks like what's left is running that slotscheck linter which got lost and is now failing for whatever reason!?)*

)

* Remove overlapping slots, fix broken slots inheritance

* added "CHANGES" entry

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix refs in CHANGES

* added name to contributors

* extra clarification on CookieMixin __slots__ ignore

* add slotscheck to github CI workflow

* use "python -m" in slotscheck run to ensure aiohttp.worker module can be imported

* install base requirements for slotscheck in CI

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 65de218)
@webknjaz webknjaz added infra github_actions Pull requests that update GitHub Actions code labels Aug 17, 2026
@psf-chronographer psf-chronographer Bot added the bot:chronographer:provided There is a change note present in this PR label Aug 17, 2026
@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.66%. Comparing base (7977dcf) to head (3011858).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.15   #13466   +/-   ##
=======================================
  Coverage   95.66%   95.66%           
=======================================
  Files         160      160           
  Lines       51183    51183           
  Branches     2828     2828           
=======================================
  Hits        48964    48964           
  Misses       2039     2039           
  Partials      180      180           
Flag Coverage Δ
CI-GHA 95.63% <ø> (-0.01%) ⬇️
OS-Linux 95.41% <ø> (-0.01%) ⬇️
OS-Windows 93.15% <ø> (-0.01%) ⬇️
OS-macOS 94.59% <ø> (ø)
Py-3.10 94.76% <ø> (ø)
Py-3.11 95.04% <ø> (-0.01%) ⬇️
Py-3.12 95.12% <ø> (ø)
Py-3.13 95.11% <ø> (+<0.01%) ⬆️
Py-3.14 95.20% <ø> (ø)
Py-3.14t 94.21% <ø> (-0.01%) ⬇️
Py-pypy-3.11 94.07% <ø> (-0.01%) ⬇️
VM-macos 94.59% <ø> (ø)
VM-ubuntu 95.41% <ø> (-0.01%) ⬇️
VM-windows 93.15% <ø> (-0.01%) ⬇️
cython-coverage 78.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codspeed-hq

codspeed-hq Bot commented Aug 17, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 84 untouched benchmarks
⏩ 86 skipped benchmarks1


Comparing webknjaz:patchback/backports/3.15/65de218c6297284663eeae5c07e9146ef1e4485e/pr-6547/handcrafted-cherry-pick-by-webknjaz (3011858) with 3.15 (7977dcf)

Open in CodSpeed

Footnotes

  1. 86 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@webknjaz

Copy link
Copy Markdown
Member Author

https://github.com/aio-libs/aiohttp/actions/runs/32053849820/job/95459534867?pr=13466#step:9:51:

stats:
ERROR: 'aiohttp.web_routedef:RouteDef' defines slots but superclass does not.
  modules:     55
    checked:   54
    excluded:  1
    skipped:   0

  classes:     302
    has slots: 247
    no slots:  55
       Superclasses without slots:
       - 'aiohttp.web_routedef:AbstractRouteDef'
ERROR: 'aiohttp.web_routedef:StaticDef' defines slots but superclass does not.
       Superclasses without slots:
       - 'aiohttp.web_routedef:AbstractRouteDef'
Oh no, found some problems!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR github_actions Pull requests that update GitHub Actions code infra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants