[PR #6547/65de218c backport][3.15] Remove overlapping slots and fix broken slots inheritance - #13466
Conversation
) * Remove overlapping slots, fix broken slots inheritance * added "CHANGES" entry * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix refs in CHANGES * added name to contributors * extra clarification on CookieMixin __slots__ ignore * add slotscheck to github CI workflow * use "python -m" in slotscheck run to ensure aiohttp.worker module can be imported * install base requirements for slotscheck in CI Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 65de218)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.15 #13466 +/- ##
=======================================
Coverage 95.66% 95.66%
=======================================
Files 160 160
Lines 51183 51183
Branches 2828 2828
=======================================
Hits 48964 48964
Misses 2039 2039
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Merging this PR will not alter performance
Comparing Footnotes
|
|
https://github.com/aio-libs/aiohttp/actions/runs/32053849820/job/95459534867?pr=13466#step:9:51: |
This is a (manual) backport of PR #6547 as merged into master (65de218).
(looks like what's left is running that
slotschecklinter which got lost and is now failing for whatever reason!?)*