Skip to content

[PR #13509/2d9c5c10 backport][3.14] Fix multipart base64 edge cases - #13513

Merged
Dreamsorcerer merged 4 commits into
3.14from
patchback/backports/3.14/2d9c5c1062eff0034fb3ab120897a6c1b3ff7041/pr-13509
Aug 22, 2026
Merged

[PR #13509/2d9c5c10 backport][3.14] Fix multipart base64 edge cases#13513
Dreamsorcerer merged 4 commits into
3.14from
patchback/backports/3.14/2d9c5c1062eff0034fb3ab120897a6c1b3ff7041/pr-13509

Conversation

@patchback

@patchback patchback Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

This is a backport of PR #13509 as merged into master (2d9c5c1).

@codecov

codecov Bot commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.22%. Comparing base (3d850ee) to head (1824685).
⚠️ Report is 1 commits behind head on 3.14.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.14   #13513      +/-   ##
==========================================
+ Coverage   96.20%   96.22%   +0.01%     
==========================================
  Files         158      159       +1     
  Lines       50914    51034     +120     
  Branches     2751     2758       +7     
==========================================
+ Hits        48983    49108     +125     
+ Misses       1752     1750       -2     
+ Partials      179      176       -3     
Flag Coverage Δ
CI-GHA 96.22% <100.00%> (+0.01%) ⬆️
OS-Linux 96.00% <100.00%> (+0.01%) ⬆️
OS-Windows 93.73% <100.00%> (+0.02%) ⬆️
OS-macOS 95.22% <100.00%> (+0.02%) ⬆️
Py-3.10 95.42% <100.00%> (+0.02%) ⬆️
Py-3.11 95.66% <100.00%> (+0.02%) ⬆️
Py-3.12 95.73% <100.00%> (+0.01%) ⬆️
Py-3.13 95.73% <100.00%> (+0.01%) ⬆️
Py-3.14 95.82% <100.00%> (+0.02%) ⬆️
Py-3.14t 94.84% <100.00%> (+0.01%) ⬆️
Py-pypy-3.11 94.68% <100.00%> (+0.02%) ⬆️
VM-macos 95.22% <100.00%> (+0.02%) ⬆️
VM-ubuntu 96.00% <100.00%> (+0.01%) ⬆️
VM-windows 93.73% <100.00%> (+0.02%) ⬆️
cython-coverage 79.02% <32.25%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@greptile-apps

greptile-apps Bot commented Aug 22, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Reviews (3): Last reviewed commit: "Apply suggestion from @Dreamsorcerer" | Re-trigger Greptile

Comment thread tests/test_multipart.py Outdated
Comment thread tests/test_multipart.py Outdated
Comment thread tests/test_multipart.py Outdated
Comment thread tests/test_multipart.py Outdated
Comment thread tests/test_multipart.py Outdated
Comment thread tests/test_benchmarks_multipart.py Outdated
Comment thread tests/test_benchmarks_multipart.py Outdated
Comment thread tests/test_benchmarks_multipart.py Outdated
Comment thread tests/test_benchmarks_multipart.py Outdated
Comment thread tests/test_benchmarks_multipart.py Outdated
Comment thread tests/test_benchmarks_multipart.py Outdated
Comment thread tests/test_benchmarks_multipart.py Outdated
Dreamsorcerer and others added 2 commits August 22, 2026 17:36
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
Comment thread tests/test_benchmarks_multipart.py Outdated
@codspeed-hq

codspeed-hq Bot commented Aug 22, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 72 untouched benchmarks
🆕 2 new benchmarks
⏩ 7 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
🆕 test_read_base64_part[pyloop] N/A 7.4 ms N/A
🆕 test_read_chunk_base64_realignment[pyloop] N/A 3.1 ms N/A

Comparing patchback/backports/3.14/2d9c5c1062eff0034fb3ab120897a6c1b3ff7041/pr-13509 (1824685) with 3.14 (8cfbe9a)

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Dreamsorcerer
Dreamsorcerer merged commit a555ab6 into 3.14 Aug 22, 2026
47 checks passed
@Dreamsorcerer
Dreamsorcerer deleted the patchback/backports/3.14/2d9c5c1062eff0034fb3ab120897a6c1b3ff7041/pr-13509 branch August 22, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant