Skip to content

Conversation

@akiradeveloper
Copy link
Owner

After visualizing the log state by sorock-monitor, I found that non-leader nodes in mrbench doesn't do any compaction.

After some investigation I found that make_snapshot (implemented as read request because it doesn't operate on the app state) is executed in only leader node because the request is proxied to leader.

The solution is to add read_locally flag to read request.

@akiradeveloper akiradeveloper self-assigned this Oct 18, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.60%. Comparing base (6e9d66b) to head (b0c9a0f).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
- Coverage   85.61%   85.60%   -0.02%     
==========================================
  Files          49       49              
  Lines        3344     3348       +4     
==========================================
+ Hits         2863     2866       +3     
- Misses        481      482       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Performance] mrbench fails snapshotting on heavy load (n=3, p=1000)

3 participants