-
-
Notifications
You must be signed in to change notification settings - Fork 396
Pdf to image direct image #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Skillkiller
wants to merge
18
commits into
alam00000:main
Choose a base branch
from
Skillkiller:pdf-to-image-direct-image
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pdf to image direct image #215
Skillkiller
wants to merge
18
commits into
alam00000:main
from
Skillkiller:pdf-to-image-direct-image
+276
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renierr
reviewed
Dec 2, 2025
renierr
reviewed
Dec 2, 2025
renierr
reviewed
Dec 2, 2025
Author
|
Thank you for your feedback @renierr. I'll take care of it tomorrow. |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
I have also added progress messages to the loader popup for all PDF to Image functions. The PR description will be adjusted accordingly. |
renierr
reviewed
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update adjusts the behavior of the PDF-to-Image functions as follows:
Before adding the file extension or ZIP suffix, the base filename is cleaned by:
.pdfextensionOutput filename examples:
One page.pdf→One page.jpgMultiple pages.pdf→Multiple pages_jpgs.zipVery long filename ................................................test.pdf→ base filename is trimmed to 80 characters before adding
.pngor_pngs.zipVideo example:
Recording 2025-12-02 at 9.35.3 PM.webm
(This video does not show the changed progress messages because they were only added after a review.)
These changes were applied to the following modules:
Type of change
Since the return format for single-page PDFs has changed, this update is marked as a Breaking Change.
🧪 How Has This Been Tested?
The changes were verified through manual testing across all affected modules.
For each module, the following tests were performed:
Single-page PDF
One page.pdfand ran the conversion.Multi-page PDF
Multiple pages.pdfand ran the conversion.Checklist:
Test PDF files:
One page.pdf
Multiple pages.pdf
Expected Results:
Single-page PDFs
.pdfextension removedOne page.pdf→One page.pngVery long filename (over 80 chars).pdf→<cleaned_80_char_name>.pngMulti-page PDFs
.pdfcleanname_pngs.zipThese results should remain consistent across all updated modules.
Actual Results:
Checklist
(Only tests already failing on main are failing)