Skip to content

Conversation

@GiuseTripodi
Copy link

I looked at the available licences, and the MIT is a classic one that allows pretty much anything needed for this project: use, modification, and distribution.

The MIT license allows use, modification, and distribution for pretty much anything. I think it will suit this project.
@phinate
Copy link
Collaborator

phinate commented Dec 10, 2025

Thanks for doing this @GiuseTripodi! I agree that the MIT license is probably the simplest correct choice. I do have some comments on this PR itself.

An important thing to note: since your PR directly addresses an issue (#56), you should write "Fixes #56." at the bottom of your PR description. This will ensure the PR is directly linked to the issue; you can find one from the other, and maintainers will know that you're trying to directly address an existing issue, which will help them understand why you've made this PR. (Obviously, we talked about this directly, so I knew already! But this might not be the case in general.)

One additional point is that when making a pull request from a forked repository -- I see that you've made the changes on your own main branch, which you should avoid. It's important that you make your own branch with your changes -- there are a couple reasons for this:

  • If I make changes to my main in the meantime, and you want to sync your fork with this repo, you'd have to somehow make my changes from main work with your existing work, which you might not want if you have a second branch you're working on.
  • A smaller point, but not having a custom branch name makes it harder for me to understand what the branch is for. I would suggest making an informative branch name like add-license, and/or referencing the issue number Add LICENSE to template #56 that you're addressing in the branch name, like 56-add-license.

Just to summarize the steps I would now take:

  • Close this PR in favour of making one from a new branch on your fork.
  • Make the branch name informative.
  • Add the license to this branch.
  • Open a new PR from your new branch to this repositories main branch.
  • Make sure to include the relevant issue in the PR. (On GitHub, you can literally type #my-cool-issue-number (e.g. #56 like I did) and it will automatically link it for you!)

Thanks again for looking at this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants