Add check for unknown types that have a size

Author: Iain-S

sqlsynthgen/make.py

@@ -255,7 +255,7 @@ def _get_provider_for_column(column: Column) -> Tuple[list[str], str, list[str]]
             column_type,
             column.name,
         )
-    if column_size:
+    elif column_size:
         generator_arguments.append(str(column_size))
 
     return variable_names, generator_function, generator_arguments

tests/examples/example_orm.py

@@ -18,7 +18,7 @@
     UniqueConstraint,
     Uuid,
 )
-from sqlalchemy.dialects.postgresql import CIDR
+from sqlalchemy.dialects.postgresql import BIT, CIDR
 from sqlalchemy.orm import DeclarativeBase, Mapped, mapped_column, relationship
 import datetime
 
@@ -78,6 +78,7 @@ class StrangeTypeTable(Base):
 
     id: Mapped[int] = mapped_column(Integer, primary_key=True)
     column_with_unusual_type: Mapped[Optional[Any]] = mapped_column(CIDR)
+    column_with_unusual_type_and_length: Mapped[Optional[Any]] = mapped_column(BIT(3))
 
 
 class UnignorableTable(Base):

tests/examples/expected_ssg.py

@@ -99,6 +99,7 @@ def __init__(self):
     def __call__(self, dst_db_conn):
         result = {}
         result["column_with_unusual_type"] = generic.null_provider.null()
+        result["column_with_unusual_type_and_length"] = generic.null_provider.null()
         return result
 
 

tests/examples/src.dump

@@ -224,7 +224,8 @@ ALTER TABLE public.table_to_be_ignored OWNER TO postgres;
 
 CREATE TABLE public.strange_type_table (
     id integer NOT NULL,
-    column_with_unusual_type cidr
+    column_with_unusual_type cidr,
+    column_with_unusual_type_and_length bit(3)
 );
 
 ALTER TABLE public.strange_type_table OWNER TO postgres;

tests/test_functional.py

@@ -108,6 +108,11 @@ def test_workflow_minimal_args(self) -> None:
             "for column column_with_unusual_type. "
             "Setting this column to NULL always, "
             "you may want to configure a row generator for it instead.\n"
+            "Unsupported SQLAlchemy type "
+            "<class 'sqlalchemy.dialects.postgresql.types.BIT'> "
+            "for column column_with_unusual_type_and_length. "
+            "Setting this column to NULL always, "
+            "you may want to configure a row generator for it instead.\n"
             "A unique constraint (ab_uniq) isn't fully covered by one "
             "row generator (['a']). Enforcement of the constraint may not work.\n"
             "A unique constraint (ab_uniq) isn't fully covered by one "
@@ -267,6 +272,11 @@ def test_workflow_maximal_args(self) -> None:
             "<class 'sqlalchemy.dialects.postgresql.types.CIDR'> "
             "for column column_with_unusual_type. "
             "Setting this column to NULL always, "
+            "you may want to configure a row generator for it instead.\n"
+            "Unsupported SQLAlchemy type "
+            "<class 'sqlalchemy.dialects.postgresql.types.BIT'> "
+            "for column column_with_unusual_type_and_length. "
+            "Setting this column to NULL always, "
             "you may want to configure a row generator for it instead.\n",
             completed_process.stderr.decode("utf-8"),
         )