Add DataFusion parquet range cache#3
Closed
alexanderbianchi wants to merge 1 commit intobianchi/parquet-footer-cachefrom
Closed
Add DataFusion parquet range cache#3alexanderbianchi wants to merge 1 commit intobianchi/parquet-footer-cachefrom
alexanderbianchi wants to merge 1 commit intobianchi/parquet-footer-cachefrom
Conversation
Owner
Author
|
Closing this fork-only stacked PR. Re-opening upstream against quickwit-oss/quickwit with both commits included. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a DataFusion-local parquet byte-range cache on top of the footer metadata cache work in quickwit-oss#6388.
The cache is installed through the Quickwit DataFusion object-store bridge and uses Quickwit's existing in-memory
MemorySizedCachemachinery. Cache keys are scoped by storage URI to avoid collisions across buckets or authorities.Also adds an internal note describing the path to a follow-up Foyer-backed block/range cache and when that extra complexity is likely justified.
Validation
cargo check -p quickwit-serve --features datafusioncargo test -p quickwit-datafusioncargo test -p quickwit-storage --features testsuitecargo check -p quickwit-lambda-servergit diff --check