fix(preset-algolia): keep separator highlight when reverse-highlight siblings disagree

[devteamaegis]

What's broken

In the reverse-highlight / reverse-snippet "sibling strategy", isPartHighlighted computes neighbor state with ||:

const isNextHighlighted = parts[i + 1]?.isHighlighted || true;
const isPreviousHighlighted = parts[i - 1]?.isHighlighted || true;

X || true is always true, even when the neighbor exists and is genuinely false. So the isPreviousHighlighted === isNextHighlighted guard is always true, and every separator part between mismatched neighbors is wrongly treated as highlighted-from-siblings. For a value where a separator sits between a highlighted and a non-highlighted segment, the reverse-highlight output is wrong.

Why it happens

|| was used where a "default only when the neighbor is missing" was intended — the ?. optional chaining shows the intent. false || true collapses a real false neighbor to true.

Fix

Use ?? so the true default applies only when the neighbor is absent (undefined).

Test

Added a case: a separator between a highlighted and a non-highlighted segment keeps its own state; fails before, passes after. Full autocomplete-preset-algolia suite stays green.

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{TIP This summary will be updated as you push new changes.}