feat(keychain): add per-app secret store#233
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 15 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
LorrisSaintGenez
requested review from
8bittitan,
NatanTechofNY,
dylantientcheu and
pipeline1987
Avoids a config<->auth import cycle: the upcoming read-resolution step (pkg/config) needs LoadAppSecrets, but pkg/auth already imports pkg/config. A neutral pkg/keychain package both can depend on. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
LorrisSaintGenez
changed the title
8bittitan
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
pkg/keychain(SaveAppSecrets/LoadAppSecrets), backed by the OS keychain (servicealgolia-cli, userapp:<application_id>, JSON{api_key, crawler_api_key}).pkg/auth) so the upcoming read-resolution step inpkg/configcan use it without aconfig↔authimport cycle.(nil, nil); keychain-unavailable / malformed-JSON → error; emptyappIDrejected. No callers yet.Test
go test ./pkg/keychain -v