Skip to content

Conversation

@owenatgov
Copy link
Contributor

@owenatgov owenatgov commented Nov 3, 2025

What it says on the tin.

Addresses a small part of alphagov/govuk-frontend#5786

@owenatgov owenatgov force-pushed the govuk-branded-service-nav branch from f9c8ff7 to 7017201 Compare November 3, 2025 14:40
@joelanman
Copy link
Contributor

I think this was already done (using layouts/main) here

#2451

@owenatgov
Copy link
Contributor Author

owenatgov commented Nov 4, 2025

@joelanman Is that other change overriding what's coming from this template? I'm trying to get rid of the serviceName in the header of this govuk branded template as per alphagov/govuk-frontend#5786. Would this also apply to adding templates?

@joelanman
Copy link
Contributor

happy to have a quick meeting, this might need some talking through, I think:

  • the other PR does override the header, including pages made from common templates (common templates all inherit layouts/main)
  • it only covers new prototypes created since that release
  • this is probably the right thing to do anyway if servicename is being removed
  • then we don't need it in the starter layout/main any more
  • if people have custom header blocks in layouts/main (or anywhere else) theirs will still override this, but I guess the worst that would happen is servicename no longer appears in the main header, I don't think it would error

@owenatgov
Copy link
Contributor Author

@joelanman Gotcha, thank you! I'll make a note of this and include it in chats about a new breaking change.

@owenatgov
Copy link
Contributor Author

Things have progressed quite a bit in the v6 prototype kit work so I'm closing this for the mo

@owenatgov owenatgov closed this Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants