Fix text insertion mode description wrapping - #791
Conversation
|
The PR Policy check is blocking this PR because required template information is missing. Please update the PR description with:
Visual files detected:
Screenshots or video are required for UI, UX, settings, onboarding, overlay, menu bar, or visual behavior changes. If this PR has no visual changes, check the no-visual-change box in the template. If this remains incomplete for 48 hours after opening, the PR may be closed. |
Greptile SummaryThe PR updates Settings option rows so descriptions can wrap at narrow window widths while activation and insertion mode pickers retain their fixed width.
|
|
But why wrap only one field while rest are hanging? |
|
Good point. I updated the shared Options description layout so all toggle descriptions wrap consistently, and adjusted Activation Mode to follow the same layout instead of special-casing Text Insertion Mode. That is in commit |
97f40a8 to
38d566b
Compare
|
Following up on the earlier feedback: option descriptions now wrap consistently across the shared Settings layout, and the branch is current with |
|
Hi, thanks for the nice PR. Would you be able to attach a screenshot so I can take a look at it? Thank you so much. |
|
This pull request has been marked stale because it has had no activity for 5 days. It will be closed in 2 days if there is no further activity. Add the |
|
Keeping this open. The fix is still applicable on current |
38d566b to
90c103c
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
there was a settings redo recently. If tihs still works well, down to merge it as is! |

Description
Allow option descriptions in Settings to wrap instead of truncating at narrower window widths. Shared toggle rows now wrap consistently, and the Activation Mode and Text Insertion Mode descriptions take the available leading space while their pickers keep the existing fixed width.
Type of Change
Related Issue or Discussion
Closes #776.
Testing
swiftlint --strict --config .swiftlint.yml Sources(SwiftLint is not installed locally)swiftformat --config .swiftformat Sources(SwiftFormat is not installed locally)xcodebuild test -project Fluid.xcodeproj -scheme Fluid -destination 'platform=macOS,arch=arm64'Also verified with
swiftc -parse,git diff --check, an unsigned app build, and narrow-width visual QA.Screenshots / Video
After: narrow Settings window showing Activation Mode, Text Insertion Mode, and the shared option rows wrapping beside fixed-width controls.
Notes
AI assistance: Codex was used for implementation and validation.