Skip to content

Fix text insertion mode description wrapping - #791

Merged
altic-dev merged 2 commits into
altic-dev:mainfrom
so1omon563:codex/issue-776-text-insertion-wrap
Aug 30, 2026
Merged

Fix text insertion mode description wrapping#791
altic-dev merged 2 commits into
altic-dev:mainfrom
so1omon563:codex/issue-776-text-insertion-wrap

Conversation

@so1omon563

@so1omon563 so1omon563 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Description

Allow option descriptions in Settings to wrap instead of truncating at narrower window widths. Shared toggle rows now wrap consistently, and the Activation Mode and Text Insertion Mode descriptions take the available leading space while their pickers keep the existing fixed width.

Type of Change

  • 🐞 Bug fix
  • ✨ New feature
  • 💥 Breaking change
  • 🧹 Chore
  • 📝 Documentation update

Related Issue or Discussion

Closes #776.

Testing

  • Tested on Intel Mac
  • Tested on Apple Silicon Mac
  • Tested on macOS version: 26.5.2
  • Ran linter locally: swiftlint --strict --config .swiftlint.yml Sources (SwiftLint is not installed locally)
  • Ran formatter locally: swiftformat --config .swiftformat Sources (SwiftFormat is not installed locally)
  • Ran tests locally: xcodebuild test -project Fluid.xcodeproj -scheme Fluid -destination 'platform=macOS,arch=arm64'

Also verified with swiftc -parse, git diff --check, an unsigned app build, and narrow-width visual QA.

Screenshots / Video

After: narrow Settings window showing Activation Mode, Text Insertion Mode, and the shared option rows wrapping beside fixed-width controls.

Settings option descriptions wrapping at narrow window width
  • No UI/visual changes; screenshots/video are not applicable.

Notes

AI assistance: Codex was used for implementation and validation.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

The PR Policy check is blocking this PR because required template information is missing.

Please update the PR description with:

  • Screenshots / Video

Visual files detected:

  • Sources/Fluid/UI/SettingsView.swift

Screenshots or video are required for UI, UX, settings, onboarding, overlay, menu bar, or visual behavior changes. If this PR has no visual changes, check the no-visual-change box in the template.

If this remains incomplete for 48 hours after opening, the PR may be closed.

@github-actions github-actions Bot added needs screenshots Pull request needs screenshot or video evidence. and removed needs screenshots Pull request needs screenshot or video evidence. labels Aug 5, 2026
@so1omon563
so1omon563 marked this pull request as ready for review August 5, 2026 16:05
@greptile-apps

greptile-apps Bot commented Aug 5, 2026

Copy link
Copy Markdown

Greptile Summary

The PR updates Settings option rows so descriptions can wrap at narrow window widths while activation and insertion mode pickers retain their fixed width.

  • Makes shared toggle descriptions vertically expandable.
  • Gives Activation Mode and Text Insertion Mode descriptions the available leading space.
  • Removes the per-row wrapping flag now that wrapping is consistent.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Reviews (4): Last reviewed commit: "Wrap option descriptions consistently" | Re-trigger Greptile

@altic-dev

Copy link
Copy Markdown
Owner

But why wrap only one field while rest are hanging?

@so1omon563

Copy link
Copy Markdown
Contributor Author

Good point. I updated the shared Options description layout so all toggle descriptions wrap consistently, and adjusted Activation Mode to follow the same layout instead of special-casing Text Insertion Mode.

That is in commit 97f40a8. I rechecked Swift parsing, git diff --check, the unsigned build, and the narrow-width Settings layout.

@so1omon563
so1omon563 force-pushed the codex/issue-776-text-insertion-wrap branch from 97f40a8 to 38d566b Compare August 19, 2026 17:20
@so1omon563

Copy link
Copy Markdown
Contributor Author

Following up on the earlier feedback: option descriptions now wrap consistently across the shared Settings layout, and the branch is current with main. Local validation and PR checks are green whenever you have a chance to take another look.

@altic-dev

Copy link
Copy Markdown
Owner

Hi, thanks for the nice PR. Would you be able to attach a screenshot so I can take a look at it? Thank you so much.

Copy link
Copy Markdown
Contributor Author

Whoops, the screenshot was still from the earlier version of the fix. I’ve replaced it with an updated one showing the broader wrapping changes across Activation Mode, Text Insertion Mode, and the shared option rows.

Settings option descriptions wrapping at narrow window width

@github-actions

Copy link
Copy Markdown

This pull request has been marked stale because it has had no activity for 5 days. It will be closed in 2 days if there is no further activity. Add the keep-open or pinned label to prevent automatic closure.

@github-actions github-actions Bot added the stale label Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Keeping this open. The fix is still applicable on current main, and I’m refreshing the branch now.

@so1omon563
so1omon563 force-pushed the codex/issue-776-text-insertion-wrap branch from 38d566b to 90c103c Compare August 30, 2026 01:33
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-30T01:35:03.628497Z 90c103c New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@altic-dev

Copy link
Copy Markdown
Owner

there was a settings redo recently. If tihs still works well, down to merge it as is!

@altic-dev
altic-dev merged commit 33c8b33 into altic-dev:main Aug 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]

2 participants