Skip to content

Add language selection for Whisper models - #890

Merged
altic-dev merged 6 commits into
altic-dev:mainfrom
wallneradam:codex/whisper-language-selection
Aug 26, 2026
Merged

Add language selection for Whisper models#890
altic-dev merged 6 commits into
altic-dev:mainfrom
wallneradam:codex/whisper-language-selection

Conversation

@wallneradam

Copy link
Copy Markdown
Contributor

Description

Adds a searchable language selector to every Whisper model in Voice Engine settings. Users can keep automatic language detection or force one of Whisper's 99 supported languages.

The selected language is persisted, included in settings backups, and passed to RunOptions.language for transcription. Existing installations initially inherit the language selected during onboarding until the user explicitly chooses Automatic or another language.

This is particularly important for Hungarian and other languages where short utterances do not provide enough context for reliable automatic detection. Forcing the known language materially improves short and single-word dictation. It is also noticeably faster in practical Hungarian use because Whisper can skip language detection.

Automatic detection remains the default. Parakeet behavior is unchanged. The UI follows the model-specific language-selection pattern already used for Cohere and Nemotron.

This replaces #674, which was closed when its fork was accidentally deleted. The original discussion and successful review remain available there.

Type of Change

  • 🐞 Bug fix
  • ✨ New feature
  • 💥 Breaking change
  • 🧹 Chore
  • 📝 Documentation update

Related Issue or Discussion

Revisits #100 and supersedes #674.

Testing

  • Tested on Intel Mac
  • Tested on Apple Silicon Mac
  • Tested on macOS version: 26.5.2
  • Ran strict SwiftLint on the current base: 158 files, 0 violations
  • Built the application and complete test bundle against the current main with build-for-testing
  • Previously ran the complete 1.6.9 test suite: 284 tests passed with 0 failures
  • Manually tested selecting Hungarian, searching the language list, and Hungarian dictation in the installed application

Screenshots / Video

Whisper language picker

Notes

  • Uses the existing VoiceEngineLanguageCatalog; no duplicate language list or dependency update is introduced.
  • Automatic detection preserves the previous behavior.
  • Onboarding Whisper routes apply their existing language binding instead of discarding it.

@greptile-apps

greptile-apps Bot commented Aug 23, 2026

Copy link
Copy Markdown

Greptile Summary

Adds persisted, backup-compatible language selection for Whisper models and passes the selected language to transcription.

  • Adds a searchable Automatic-or-language picker to each Whisper model.
  • Integrates Whisper language bindings with onboarding routes.
  • Adds language mapping, persistence, backup/restore support, and focused integration tests.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Reviews (2): Last reviewed commit: "preserve whisper automatic detection" | Re-trigger Greptile

@altic-dev

Copy link
Copy Markdown
Owner

Thanks for the PR!

@altic-dev
altic-dev merged commit d8fc5ba into altic-dev:main Aug 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants