Skip to content

Updated settings navigation in side panel - #894

Open
grohith327 wants to merge 3 commits into
mainfrom
rohith/updated-settings-panel
Open

Updated settings navigation in side panel#894
grohith327 wants to merge 3 commits into
mainfrom
rohith/updated-settings-panel

Conversation

@grohith327

Copy link
Copy Markdown
Collaborator

Description

  • Updated settings panel in the navbar
  • Added button hover

Type of Change

  • 🐞 Bug fix
  • ✨ New feature
  • 💥 Breaking change
  • 🧹 Chore
  • 📝 Documentation update

Related Issue or Discussion

#1

Testing

  • Tested on Apple Silicon Mac
  • Tested on macOS version: 26
  • Ran linter locally: swiftlint --strict --config .swiftlint.yml Sources
  • Ran formatter locally: swiftformat --config .swiftformat Sources
  • Ran tests locally:

Screenshots / Video

settings.mp4

Notes

Add reviewer context, rollout notes, or known tradeoffs here.

@greptile-apps

greptile-apps Bot commented Aug 25, 2026

Copy link
Copy Markdown

Greptile Summary

This PR reorganizes settings into a dedicated sidebar with section-based navigation and preserves the prior app destination when returning from settings.

  • Adds shared navigation state for app and settings destinations.
  • Routes menu-bar Settings and Microphone Settings actions into the new settings sections.
  • Splits the settings content into General, Dictation, Notifications, Audio, Overlay, and Data & Diagnostics sections.
  • Adds navigation-state tests and hover/transition styling.

Confidence Score: 5/5

The PR appears safe to merge because no eligible blocking failure remains.

The previously reported Getting Started landing behavior was explicitly acknowledged as intentional and withdrawn, so no blocking failure remains.

Reviews (2): Last reviewed commit: "updates" | Re-trigger Greptile

Comment thread Sources/Fluid/ContentView.swift

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4128a35c73

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/Fluid/ContentView.swift
Comment thread Sources/Fluid/ContentView.swift
@github-actions

Copy link
Copy Markdown

FluidVoice PR build ready

Download FluidVoice-PR-894-4128a35c7382

The artifact contains the ad-hoc-signed app ZIP, Xcode archive, build manifest, and installation instructions. It expires 5 days after the build.

Install the app

  1. Extract the downloaded artifact, then extract FluidVoice-PR-894.app.zip.

  2. Move FluidVoice Updated settings navigation in side panel #894.app into the /Applications folder.

  3. Open Terminal and remove the download quarantine marker:

    xattr -dr com.apple.quarantine "/Applications/FluidVoice #894.app"
    
  4. In Applications, Control-click FluidVoice Updated settings navigation in side panel #894.app and choose Open.

  5. If macOS still blocks it, open System Settings → Privacy & Security, click Open Anyway, and confirm.

This build has its own app identity, so its permissions are separate from the release version of FluidVoice.

View workflow run

@grohith327

Copy link
Copy Markdown
Collaborator Author

@greptileai review again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant