Changed the logic for checking if the module is turned on#212
Closed
glinkinvd wants to merge 3 commits intoaltlinux:masterfrom
Closed
Changed the logic for checking if the module is turned on#212glinkinvd wants to merge 3 commits intoaltlinux:masterfrom
glinkinvd wants to merge 3 commits intoaltlinux:masterfrom
Conversation
Collaborator
|
Regarding the commits with proposed code refactoring: these changes should be submitted as a separate pull request that proposes a consistent style change across the entire project. Such a PR should include thorough testing to ensure functionality is preserved. Code style changes should be isolated from functional changes to make review and testing more straightforward. |
59bbc66 to
159127d
Compare
Contributor
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, machine applier applied custom policies due to bad logic in check_enabled() in the applier_frontend.py file.
It used to be like this
If the module is not in dconf, we returned True for some reason and enabled it. This is not a very good approach.
With my commit, the logic got better.