Set %DesktopDir% as the default path if the Windows variable is unknown#213
Set %DesktopDir% as the default path if the Windows variable is unknown#213glinkinvd wants to merge 1 commit intoaltlinux:masterfrom
Conversation
|
For all other fixes related to code refactoring, a separate pull request should be made, implementing changes throughout the entire project and testing its functionality after these modifications. Regarding the changes aimed at simplifying the code, remember that the simplest solution isn't always the best one. |
|
Do I understand correctly that you are proposing to leave only functional changes in all the proposed PRs? In all PRs I refactored the code using black formatter (https://pypi.org/project/black/) and pylint linter (https://pypi.org/project/pylint/) to make the code at least somehow start to conform to PEP 8 (PEP 8 - Style Guide for Python Code). Basically, I tried to make as harmless changes as possible, preserving previously implemented functionality. The project's README recommends using linter from 2020, but judging by the state of the code, it's like it's never been used. |
|
About replacing list() with [] and why so: About replacing dict() with {} and why so: About PascalCase: |
No, I suggest separating pull requests into functional changes versus refactoring. Such pull requests are easier to accept and discuss with the sender regarding inaccuracies that can be fixed or don't need to be made at all. Also, regarding refactoring changes to the code, I want to note that they only make sense when applied across the entire project, not just in specific files. |
Roger that. In that case, tonight I will move everything related to refactoring to separate PRs, and leave only functional ones in the already open ones |
Done |
2 participants
No description provided.