NetworkPlugin update: adding url collector arg and test enhancements #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaspals3123
requested review from
alexandraBara and
landrews-amd
as code owners
alexandraBara
requested changes
Feb 2, 2026
| Returns: | ||
| bool: True if network is accessible, False otherwise | ||
| """ | ||
| cmd = "ping" |
Collaborator
There was a problem hiding this comment.
this needs to be defined as a class var like "CMD_PING" so it can get picked up by the auto doc generation script.
| # Run ping command | ||
| result = self._run_sut_cmd(f"{cmd} {url} {ping_option}") | ||
|
|
||
| network_accessible = result.exit_code == 0 |
Collaborator
There was a problem hiding this comment.
we dont need this extra var here, just use the result like:
if result.exit_code == 0:....
Collaborator
|
Please update the functional test for this plugin and add the collector arg to the plugin_config: https://github.com/amd/node-scraper/blob/development/test/functional/fixtures/network_plugin_config.json |
alexandraBara
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.