Harden serving recipe cache freshness and provenance - #202
Open
amd-mkarvir wants to merge 2 commits into
Open
Conversation
Comment on lines
+91
to
+108
| # The serving recipe cache controls model compatibility and the container | ||
| # image agents deploy. Exercise its fail-closed freshness and immutable-image | ||
| # selection without making network requests. | ||
| test-serving-recipe-cache: | ||
| name: Test serving recipe cache | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Check out repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up uv | ||
| uses: astral-sh/setup-uv@v7 | ||
|
|
||
| - name: Test recipe cache | ||
| run: >- | ||
| uv run --with pyyaml python -m unittest discover | ||
| -s skills/serving-llms-on-instinct/scripts/tests -v | ||
|
|
Collaborator
There was a problem hiding this comment.
Same comment as in the last PR: All workflows are skill-agnostic. Please do not modify anything inside .github/workflows to enable skill-specific tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The bundled recipe snapshot is a fallback and can become stale. The previous helper always exited successfully when refresh failed, allowing callers to continue without a reliable freshness signal. It also selected an older Docker version simply because it was updated recently, and it did not record the image digest needed to reproduce the exact container.
This change makes refresh failures observable and keeps stale fallback use explicit.
Validation
This complements #126: that PR expands behavioral coverage, while this change hardens the deterministic cache and provenance path.