Add flag to show duration for live content (Issue 3239)#3282
Open
MatthewDCantor wants to merge 5 commits into
Open
Add flag to show duration for live content (Issue 3239)#3282MatthewDCantor wants to merge 5 commits into
MatthewDCantor wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3260: In the case of event playlist live content that is long running, it can useful to allow user's to scrub through the content. However, due the changes from this issue #1758, that is no longer an option.
Solution:
It was suggested in the issue thread that there could be a flag in the MediaSession builder which could allow devs to decide if they want to show the seek bar for live content. Below is a summary of the changes:
Add new flag, showPlaybackPositionForLiveStreams to MediaSession and MediaLibraryService
Add setters for the new flag
Add test coverage for the new case