fix(share): render all turns as scrollable list instead of single-turn + nav#25081
Open
workdocyeye wants to merge 1 commit intoanomalyco:devfrom
Open
fix(share): render all turns as scrollable list instead of single-turn + nav#25081workdocyeye wants to merge 1 commit intoanomalyco:devfrom
workdocyeye wants to merge 1 commit intoanomalyco:devfrom
Conversation
…n + nav
Desktop share page previously showed one turn at a time with
MessageNav sidebar navigation. The turns() scrollable list view
already existed for mobile but was gated behind a responsive tab.
This change replaces the desktop MessageNav + single SessionTurn
layout with the scrollable For-each loop, showing all conversation
turns in one continuous scroll. This matches the standard UX pattern
of most chat applications.
Changes:
- Remove MessageNav import and usage
- Remove store/activeMessage/setActiveMessage state management
- Replace single SessionTurn with <For each={messages()}>
- provider/modelID now references firstUserMessage() directly
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #18567
Type of change
What does this PR do?
The shared conversation viewer (opncd.ai/share/*) currently uses a MessageNav sidebar on desktop that shows generic labels and requires clicking individual turns to view them. This is confusing and non-obvious navigation.
This PR removes the MessageNav sidebar and renders all conversation turns as a continuous scrollable list, matching the UX pattern of standard chat applications. The desktop two-column layout with SessionReview (diff panel) is preserved.
Changes:
MessageNavcomponent and importcreateStore/activeMessage/setActiveMessagestate management<SessionTurn>with<For each={messages()}>loopprovider/modelIDnow referencefirstUserMessage()directlySessionReviewside-by-side layout preservedTabslayout unchangedHow did you verify your code works?
SessionReview) still renders correctly in two-column layoutTabslayout is unaffectedScreenshots / recordings
N/A - layout change only
Checklist