feat: editable allow all#25088
Open
al-prk wants to merge 2 commits intoanomalyco:devfrom
Open
Conversation
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #25089
Type of change
What does this PR do?
When a permission request is approved with Allow always, the TUI currently only lets you confirm the server-suggested patterns. That makes cases like
devcontainer exec lsawkward, because the suggested rule is often much broader than what you actually want to allow.This change makes the Allow always step editable. The prompt now opens a textarea pre-filled with the suggested patterns, and the user can replace them with narrower rules before confirming.
On the backend, the permission reply payload now accepts optional
patterns. If custom patterns are provided, those are stored for the session. If the textarea is left empty, the existing behavior is preserved and OpenCode falls back to the server-suggested patterns.How did you verify your code works?
bun typecheckinpackages/opencodebun test test/permission/next.test.tsinpackages/opencodealwayspatternsEnterconfirmsEsccancelsAlt+Enterinserts a newlineScreenshots / recordings
Checklist