fix: route child session events to parent ACP session (#21802)#25165
Closed
only21mil wants to merge 1 commit intoanomalyco:devfrom
Closed
fix: route child session events to parent ACP session (#21802)#25165only21mil wants to merge 1 commit intoanomalyco:devfrom
only21mil wants to merge 1 commit intoanomalyco:devfrom
Conversation
ACPSessionManager only tracked sessions created via session/new or
session/load. Child sessions spawned by the Task tool via
Session.create({ parentID: ... }) were never registered, causing
handleEvent() to silently drop all sub-agent events (tool calls,
text streaming, permission requests).
Added childToRoot map in ACPSessionManager to resolve child session
IDs to their root ACP session. Added session.created handler in
agent.ts to register child sessions when the Task tool spawns them,
and session.deleted handler for cleanup.
Closes anomalyco#21802
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
github-actions
Bot
added
the
needs:compliance
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential duplicate found:
You should check if #21801 has already been merged or if it was abandoned, as they appear to be addressing the same underlying issue (#21802). |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
github-actions
Bot
removed
the
needs:compliance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
ACPSessionManageronly tracked sessions created viasession/neworsession/load. Child sessions spawned by the Task tool viaSession.create({ parentID: ... })were never registered, causinghandleEvent()to silently drop all sub-agent events — tool calls, text streaming, and permission requests.Changes
packages/opencode/src/acp/session.ts(+22,-1): AddedchildToRootmap,registerChild(),unregisterChild(), and updatedtryGet()to check the child→root mappingpackages/opencode/src/acp/agent.ts(+13): Addedsession.createdhandler to register child sessions, andsession.deletedhandler for cleanupTest Results
Closes #21802