fix(opencode): disable mouse tracking on exit#8355
Open
perdream wants to merge 1 commit intoanomalyco:devfrom
Open
fix(opencode): disable mouse tracking on exit#8355perdream wants to merge 1 commit intoanomalyco:devfrom
perdream wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: I found potentially related PRs:
These PRs appear to be addressing the same or overlapping concerns around proper terminal state restoration when exiting the TUI. Check if these are already merged or closed before proceeding with PR #8355. |
Contributor
|
this maybe a better - more generalized fix - i will try to test today! |
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6912
Problem
Mouse tracking ANSI sequences were not being disabled when exiting via
/exitcommand because
process.exit(0)was called before the cleanup sequencescould be flushed to the terminal.
Solution
cleanupTerminal()function that synchronously writes disable mousetracking sequences using
fs.writeSync(1, ...)to ensure immediate executiondestroyRenderer()export for SIGINT handler to properly cleanuprenderer.destroy()to ensure sequences are sentChanges
packages/opencode/src/cli/cmd/tui/context/exit.tsx: Added terminal cleanup logicpackages/opencode/src/cli/cmd/tui/app.tsx: Updated SIGINT handler to use new cleanupTesting
bun dev/exit- mouse tracking is now properly disabledCtrl+C- mouse tracking is also properly disabled