types: Initial stab at types #627
Draft
+13,498
−1,346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gobot1234
changed the title
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
# Conflicts: # src/ansys/fluent/interface/post_objects/meta.py # src/ansys/fluent/visualization/containers.py
for more information, see https://pre-commit.ci
Gobot1234
commented
Dec 27, 2025
Comment on lines
-146
to
-154
| from ansys.fluent.visualization import Graphics | ||
|
|
||
| graphics_session = Graphics(session) | ||
| surface1 = graphics_session.Surfaces["surface-1"] | ||
| surface1.definition.type = "iso-surface" | ||
| surface1.definition.iso_surface.field= "velocity-magnitude" | ||
| surface1.definition.iso_surface.rendering= "contour" | ||
| surface1.definition.iso_surface.iso_value = 0.0 | ||
| surface1.display("window-0") |
Gobot1234
commented
Dec 27, 2025
| elif obj.__class__.__name__ == "XYPlot": | ||
| elif isinstance(obj, XYPlot): | ||
| self._fetch_xy_data(obj) | ||
| elif obj.__class__.__name__ == "MonitorPlot": |
Collaborator
Author
There was a problem hiding this comment.
This is suspicious
Collaborator
Author
|
note to self need to run pyupgrade on these as well |
Gobot1234
commented
Jan 20, 2026
Collaborator
Author
There was a problem hiding this comment.
Note to self: This is a very bugged file please relook
Gobot1234
commented
Jan 20, 2026
| ) | ||
|
|
||
| def __init__(self, field: str, surfaces: List[str], solver: Optional = None): | ||
| def __init__(self, field: str, surfaces: list[str], solver: Optional = None): |
Collaborator
Author
There was a problem hiding this comment.
solver shouldn't be optional like that
Collaborator
Author
|
I need to go through the docs and strip the types as agreed in the pyfluent type checking issue |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.