fix: guard transport.close() with try/finally in Query.close()#959
Closed
itxaiohanglover wants to merge 1 commit into
Closed
fix: guard transport.close() with try/finally in Query.close()#959itxaiohanglover wants to merge 1 commit into
itxaiohanglover wants to merge 1 commit into
Conversation
If any cleanup step preceding transport.close() raises an exception (e.g. batcher.close(), task.wait(), message_send.close()), the transport is never closed, leaving the stderr reader task and CLI subprocess leaked. Wrap cleanup in try/finally to ensure transport teardown always runs. Closes anthropics#886
Author
|
Closing as duplicate of #887 which already addresses this issue. Apologies for the oversight. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Query.close()withtry/finallyso thattransport.close()always runs, even if a preceding step (batcher close, task cancellation/wait, message send close) raises an exception.Closes #886
Test plan
tests/test_query.pypasstests/test_client.pypasstests/test_transport.pypassruff checkandruff formatpassmypytype checking passes