fix(transport): prioritize system-wide CLI over bundled binary in _find_cli#970
Open
anishesg wants to merge 1 commit into
Open
fix(transport): prioritize system-wide CLI over bundled binary in _find_cli#970anishesg wants to merge 1 commit into
anishesg wants to merge 1 commit into
Conversation
…nd_cli Changed the CLI discovery order in `SubprocessCLITransport._find_cli()` to search for system-wide installations (via PATH and common locations) before falling back to the bundled binary. This allows users to work around protocol incompatibilities in older bundled binaries by installing a newer version globally, without requiring an SDK upgrade. Signed-off-by: anish <anishesg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the CLI discovery order in
SubprocessCLITransport._find_cli()to search for system-wide installations (via PATH and common locations) before falling back to the bundled binary. This allows users to work around protocol incompatibilities in older bundled binaries by installing a newer version globally, without requiring an SDK upgrade.The original priority order checked the bundled CLI first, which prevented users from overriding a broken bundled binary. In containerized environments where the bundled binary v2.1.121 fails to respond to control_request:initialize messages, users can now install v2.1.128+ via npm and the SDK will automatically discover and use the working version.
The new search order:
shutil.which("cli")).npm-global/bin,/usr/local/bin, etc.)Fixes #922