fix(options): auto-inject Skill tool when skills option is set with explicit tools#979
Open
anishesg wants to merge 1 commit into
Open
fix(options): auto-inject Skill tool when skills option is set with explicit tools#979anishesg wants to merge 1 commit into
anishesg wants to merge 1 commit into
Conversation
…xplicit tools When `skills="all"` or a skill list is set alongside an explicit `tools` list in Options, the SDK was not automatically injecting the "Skill" tool into the base tools list. This caused the system to be unable to invoke skills because the Skill tool wasn't available, even though it was configured in allowed_tools. Signed-off-by: anish <anishesg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
skills="all"or a skill list is set alongside an explicittoolslist in AgentOptions, the SDK was not automatically injecting the "Skill" tool into the base tools list. This caused the agent to be unable to invoke skills because the Skill tool wasn't available, even though it was configured in allowed_tools.The root cause was in
subprocess_cli.pywhere the tools list was processed before skills handling. When users explicitly settools=["WebSearch", "WebFetch", "Read"], the Skill tool was added toallowed_toolsbut not to the basetoolslist, making it allowed but unavailable.The fix adds logic in the
_build_commandmethod to automatically append "Skill" to the tools list whenskillsis set and an explicit tools list is provided. This ensures skills work correctly regardless of whether tools are explicitly configured or not.Three regression tests have been added to cover:
skills="all"with explicit tools listskills=["name"]with explicit tools listFixes #977