Skip to content

Unlink bash tool output temp file on job cleanup #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gigioneggiando wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Unlink bash tool output temp file on job cleanup #540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ds4_agent.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6690,6 +6690,11 @@ static void agent_bash_job_free(agent_bash_job *job) {
}
if (job->pipe_fd >= 0) close(job->pipe_fd);
if (job->tmp_fd >= 0) close(job->tmp_fd);
/* Remove the mkstemp() output file created in agent_bash_start(); only
* that function's error paths unlinked it, so a job that started
* successfully otherwise leaves /tmp/ds4_agent_output_* behind for the
* lifetime of the process (unbounded accumulation across many jobs). */
if (job->path[0]) unlink(job->path);
free(job->cmd);
free(job);
}
Expand Down