Properly account for iterator opt keys with muplitple dots#6195
Open
DomGarguilo wants to merge 1 commit intoapache:2.1from
Open
Properly account for iterator opt keys with muplitple dots#6195DomGarguilo wants to merge 1 commit intoapache:2.1from
DomGarguilo wants to merge 1 commit intoapache:2.1from
Conversation
dlmarion
approved these changes
Mar 9, 2026
ddanielr
reviewed
Mar 9, 2026
| var e = assertThrows(AccumuloException.class, () -> c.namespaceOperations() | ||
| .checkIteratorConflicts(namespace, setting, EnumSet.allOf(IteratorScope.class))); | ||
| assertEquals(IllegalArgumentException.class, e.getCause().getClass()); | ||
| c.namespaceOperations().checkIteratorConflicts(namespace, setting, |
Contributor
There was a problem hiding this comment.
Why was this test changed?
ddanielr
approved these changes
Mar 9, 2026
Contributor
ddanielr
left a comment
ddanielr
left a comment
There was a problem hiding this comment.
Tested, confirmed this works as expected.
The code could be further simplified by stripping off the TABLE_ITERATOR_PREFIX and scope from the property string but that would require more code changes in 2.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6111 added increased checks when parsing iterators. One of the checks disallowed iterator opt keys to have multiple dots in it. This PR fixes that.
A new test was added to cover this case and an existing test case that was failing was fixed here.