[Hotfix] Add missing ams-optimizing-uri to Kubernetes optimizer container Helm template #4070
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
When using
KubernetesOptimizerContainer, the Helm chart template for the Kubernetes optimizer is missing theams-optimizing-uriproperty. This causes the optimizer to fall back toserver-expose-hostwhich is hardcoded to127.0.0.1in the ConfigMap, resulting in optimizer pods failing to connect to the AMS optimizing service.Both the Flink and Spark optimizer templates already include
ams-optimizing-uri, but the Kubernetes optimizer template does not.Brief change log
ams-optimizing-uriproperty to theamoro.optimizer.container.kubernetestemplate incharts/amoro/templates/_optimizer.tpl, using the sameamoro.svc.optimizing.urihelper that Flink and Spark templates use.How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Verified that the rendered Helm template now includes the correct
ams-optimizing-urivalue (thrift://{release}-optimizing.{namespace}.svc.{clusterDomain}:1261) for the Kubernetes optimizer container.Documentation